Skip to content

vendor: clean up modules by removing unneeded replaces#5499

Closed
staebler wants to merge 4 commits intoopenshift:masterfrom
staebler:cleanup_go_mod
Closed

vendor: clean up modules by removing unneeded replaces#5499
staebler wants to merge 4 commits intoopenshift:masterfrom
staebler:cleanup_go_mod

Conversation

@staebler
Copy link
Copy Markdown
Contributor

@staebler staebler commented Dec 18, 2021

No description provided.

@staebler
remove unused kube terraform provider
0267571
@staebler
vendor: update openshift/api to include some alibaba infra changes
a829541 
* Update openshift/api to 6e0b1eb97188.
* Update kube modules to v0.23.0.
* Update controller-runtime to v0.11.0.
* Remove unused terraform-provider-kubernetes.
@staebler
hack: use go 1.17 for verifying codegen
ca77dac 
The hack/verify-codegen.sh script was using an image that included
go 1.16. However, the updated k8s.io/json module calls the
`(reflect.StructField) IsExported` function, which is new in go 1.17.
Consequently, the script needs to be updated to use an image that
include go 1.17 rather than 1.16.
@staebler
vendor: cleanup go.mod to remove unneeded replaces
d61b74b
@staebler
Copy link
Copy Markdown
Contributor Author

staebler commented Dec 18, 2021

This builds on #5498.
/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 18, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from staebler after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 26, 2022

@staebler: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws d61b74b link false /test okd-e2e-aws
ci/prow/e2e-aws-single-node d61b74b link false /test e2e-aws-single-node
ci/prow/e2e-aws-workers-rhel7 d61b74b link false /test e2e-aws-workers-rhel7
ci/prow/e2e-openstack d61b74b link false /test e2e-openstack
ci/prow/e2e-aws-workers-rhel8 d61b74b link false /test e2e-aws-workers-rhel8
ci/prow/e2e-crc d61b74b link false /test e2e-crc
ci/prow/e2e-ibmcloud d61b74b link false /test e2e-ibmcloud
ci/prow/e2e-alibaba d61b74b link true /test e2e-alibaba

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 26, 2022

@staebler: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 26, 2022

@staebler: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2022
@staebler
Copy link
Copy Markdown
Contributor Author

staebler commented Mar 1, 2022

/close as obsolete

@staebler
Copy link
Copy Markdown
Contributor Author

staebler commented Mar 1, 2022

/close as obsolete

/close

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 1, 2022

@staebler: Closed this PR.

Details

In response to this:

/close as obsolete

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot closed this Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rna-afk rna-afk Awaiting requested review from rna-afk

@squidboylan squidboylan Awaiting requested review from squidboylan

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@staebler